Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support different nixpkgs locked types #119

Merged
merged 1 commit into from
Aug 2, 2024
Merged

support different nixpkgs locked types #119

merged 1 commit into from
Aug 2, 2024

Conversation

pyqlsa
Copy link
Contributor

@pyqlsa pyqlsa commented Jul 26, 2024

Avoid hard-coding the nixpkgs flakeref to github:NixOS/nixpkgs in order to handle alternate nixpkgs locations.

@pyqlsa pyqlsa force-pushed the support-nixpkgs-lock-types branch 3 times, most recently from 74ec534 to 406d260 Compare July 26, 2024 06:33
@henrirosten
Copy link
Collaborator

Thanks @pyqlsa, this change seems good to me.

The only question I have is why do you add the pkgs.git as a dependency to all the out tools in the postInstall step here?

@pyqlsa
support different nixpkgs locked types
583f497 
Signed-off-by: pyqlsa <26353308+pyqlsa@users.noreply.github.com>
@pyqlsa
Copy link
Contributor Author

pyqlsa commented Aug 1, 2024 •
edited
Loading

@henrirosten git is required to resolve git+ssh and git+https urls.

I inspected some of the other scripts a little more diligently, and only sbomnix, nix_outdated, and vulnxscan either directly or transitively depend on nixmeta.scanner.NixMetaScanner; thus, I will remove git from nixgraph and provenance.

Fix incoming shortly!

@pyqlsa pyqlsa force-pushed the support-nixpkgs-lock-types branch from 406d260 to 583f497 Compare August 1, 2024 15:50
@henrirosten henrirosten merged commit 6084414 into tiiuae:main Aug 2, 2024
3 checks passed
@henrirosten
Copy link
Collaborator

Merged, thanks @pyqlsa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyqlsa @henrirosten